gmake install fails on freebsd

[ckrey]

Problem:

...
sed -i -e "s#@CMAKE_INSTALL_PREFIX@#/usr/local#" -e "s#@VERSION@#1.6.9#" "/usr/local/lib/pkgconfig/libmosquitto.pc"
sed: -e: No such file or directory
...

Analysis:
sed in freebsd has a non-optional argument to the -i option sed(1). gsed or other versions of sed interpret a missing argument to the -i option as a zero-length argument.

Solution:
Use a zero-length argument in the two relevant Makefiles

% git diff
diff --git a/lib/Makefile b/lib/Makefile
index 2abffd7a..91507b2d 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -74,7 +74,7 @@ endif
        $(INSTALL) mqtt_protocol.h "${DESTDIR}${incdir}/mqtt_protocol.h"
        $(INSTALL) -d "${DESTDIR}${libdir}/pkgconfig"
        $(INSTALL) -m644 ../libmosquitto.pc.in "${DESTDIR}${libdir}/pkgconfig/libmosquitto.pc"
-       sed -i -e "s#@CMAKE_INSTALL_PREFIX@#${prefix}#" -e "s#@VERSION@#${VERSION}#" "${DESTDIR}${libdir}/pkgconfig/libmosquitto.pc"
+       sed -i "" -e "s#@CMAKE_INSTALL_PREFIX@#${prefix}#" -e "s#@VERSION@#${VERSION}#" "${DESTDIR}${libdir}/pkgconfig/libmosquitto.pc"
 ifeq ($(WITH_SHARED_LIBRARIES),yes)
        $(MAKE) -C cpp install
 endif
diff --git a/lib/cpp/Makefile b/lib/cpp/Makefile
index 8606da70..884bc10d 100644
--- a/lib/cpp/Makefile
+++ b/lib/cpp/Makefile
@@ -26,7 +26,7 @@ endif
        $(INSTALL) mosquittopp.h "${DESTDIR}${incdir}/mosquittopp.h"
        $(INSTALL) -d "${DESTDIR}${libdir}/pkgconfig/"
        $(INSTALL) -m644 ../../libmosquittopp.pc.in "${DESTDIR}${libdir}/pkgconfig/libmosquittopp.pc"
-       sed -i -e "s#@CMAKE_INSTALL_PREFIX@#${prefix}#" -e "s#@VERSION@#${VERSION}#" "${DESTDIR}${libdir}/pkgconfig/libmosquittopp.pc"
+       sed -i "" -e "s#@CMAKE_INSTALL_PREFIX@#${prefix}#" -e "s#@VERSION@#${VERSION}#" "${DESTDIR}${libdir}/pkgconfig/libmosquittopp.pc"

 uninstall :
        -rm -f "${DESTDIR}${libdir}/libmosquittopp.so.${SOVERSION}"

[ralight]

So was it you that switched JP over to FreeBSD, or the other way round? :)

Your fix doesn't work on my version of sed, I've put in a different fix that does the job on both systems.

[jpmens]

@ralight I switched myself over! :-)

[ckrey]

As always, JP switched me over

[ralight]

I've only dabbled on digital ocean, but that is enough for compiling and testing. If you are happy with the fix, please close the bug in your own time.