Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--remove-retained does not consider filtered topics #1585

Closed
MrMcX opened this issue Feb 5, 2020 · 2 comments
Closed

--remove-retained does not consider filtered topics #1585

MrMcX opened this issue Feb 5, 2020 · 2 comments

Comments

@MrMcX
Copy link

MrMcX commented Feb 5, 2020

The example mosquitto_sub -t 'bbc/#' -T bbc/bbc1 --remove-retained from the man page is currently not excluding the topic filtered with -T.

To achieve this, the file client/sub_client.c should be changed to move the respective block (lines 79-81) after the statement checking for filtered topics (lines 91-97)
This was referenced Feb 5, 2020
Closed
Closed
ralight added a commit that referenced this issue Feb 5, 2020
@ralight
Fix --remove-retained not obeying the -T option.
56d0b95 
This means `--remove-retained -t bbc/# -T bbc/one/#` would remove all
retained messages in `bbc/#`, instead of leaving all of the topics in
`bbc/one/#`.

Closes #1585. Thanks to Simon Moser.
@ralight
Copy link
Contributor

ralight commented Feb 5, 2020

Thank you for this. I've pushed the change that fixes this. I didn't look at the updates properly, I just saw the "ubilab-escape/operator" line and assumed they were all related to that. That means I didn't see your pull request, I'm sorry it wasn't intentional that I didn't use it.

@MrMcX
Copy link
Author

MrMcX commented Feb 5, 2020

Thank you for fixing it so fast, I had problem with signing off the commit correctly anyway ;)

@MrMcX MrMcX closed this as completed Feb 5, 2020
@MrMcX MrMcX reopened this Feb 5, 2020
@ralight ralight closed this as completed Feb 6, 2020
michaeliu added a commit to michaeliu/mosquitto that referenced this issue Feb 7, 2020
@michaeliu
Squashed commit of the following:
f766ae2 
commit f16d9e2
Author: Roger A. Light <[email protected]>
Date:   Thu Feb 6 21:05:52 2020 +0000

    Add file missing from earlier commit.

commit c4e41f3
Author: Roger A. Light <[email protected]>
Date:   Thu Feb 6 16:43:29 2020 +0000

    Back port db_dump from develop.

    Closes eclipse#1519. Thanks to Christoph Krey.

commit 2a8c1d0
Merge: 17e20de 4408339
Author: Roger A. Light <[email protected]>
Date:   Thu Feb 6 16:20:52 2020 +0000

    Merge branch 'coverity-fixes' into fixes

commit 17e20de
Author: Roger A. Light <[email protected]>
Date:   Thu Feb 6 16:12:29 2020 +0000

    Fix session-expiry-interval for v5 clients using -c.

    Default behaviour for v5 clients using `-c` is now to use infinite length
    sessions, as with v3 clients.

    Closes eclipse#1546. Thanks to Kiran Pradeep.

commit 078ad75
Author: Gianfranco Costamagna <[email protected]>
Date:   Wed Jan 22 12:29:41 2020 +0100

    cmake: add ADNS enable/disable dynamic support

    Signed-off-by: Gianfranco Costamagna <[email protected]>

commit e9a7150
Author: Gianfranco Costamagna <[email protected]>
Date:   Wed Jan 22 12:31:01 2020 +0100

    Bugfix: enabling DLT was overriding everything else on linker flags because of error in cmake set keyword

    Signed-off-by: Gianfranco Costamagna <[email protected]>

commit 7a5c2d4
Author: Gianfranco Costamagna <[email protected]>
Date:   Wed Jan 22 12:30:25 2020 +0100

    Bugfix: include "deps" directory only if BUNDLED_DEPS has been provided and set to true

    Signed-off-by: Gianfranco Costamagna <[email protected]>

commit 56d0b95
Author: Roger A. Light <[email protected]>
Date:   Wed Feb 5 15:19:55 2020 +0000

    Fix `--remove-retained` not obeying the `-T` option.

    This means `--remove-retained -t bbc/# -T bbc/one/#` would remove all
    retained messages in `bbc/#`, instead of leaving all of the topics in
    `bbc/one/#`.

    Closes eclipse#1585. Thanks to Simon Moser.

commit 3a89059
Author: Roger A. Light <[email protected]>
Date:   Tue Feb 4 17:11:11 2020 +0000

    Don't call SSL_shutdown() if SSL init hasn't completed.

commit 07c5462
Author: Roger A. Light <[email protected]>
Date:   Tue Feb 4 16:59:29 2020 +0000

    Print OpenSSL errors in more situations

    Covers when loading certificates fails, or there are ENGINE problems.

    Closes eclipse#1552. Thanks to Michael Richardson.

commit 27b4518
Author: Roger A. Light <[email protected]>
Date:   Tue Feb 4 16:05:58 2020 +0000

    Improve password file parsing in the broker and mosqitto_passwd.

    Closes eclipse#1584. Thanks to panava.

commit 4408339
Author: Roger A. Light <[email protected]>
Date:   Thu Jan 23 12:51:47 2020 +0000

    Make consts unsigned where they are compared against unsigned.

commit 5528dde
Author: Roger A. Light <[email protected]>
Date:   Thu Jan 23 12:51:12 2020 +0000

    Fix possible null dereferences.

commit 05ec02b
Author: Roger A. Light <[email protected]>
Date:   Thu Jan 23 10:55:49 2020 +0000

    Remove dead values.

commit 18f0508
Author: Roger A. Light <[email protected]>
Date:   Thu Jan 23 10:07:56 2020 +0000

    Fix dereference before null check.

    Coverity Scan 1405815.

commit db62f98
Author: Roger A. Light <[email protected]>
Date:   Thu Jan 23 09:35:28 2020 +0000

    Fix unused value being overwritten.

    Coverity Scan 1400727.
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralight @MrMcX