Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memleak in net__socket_listen #1565

Closed
back1127 opened this issue Jan 20, 2020 · 1 comment
Closed

memleak in net__socket_listen #1565

back1127 opened this issue Jan 20, 2020 · 1 comment
Milestone
1.6.9

Comments

@back1127
Copy link

call net__socket_listen and getaddrinfo.
it will allocate memory for ainfo
when listen fail it return directly. don't call freeaddrinfo.
@ralight
Copy link
Contributor

ralight commented Jan 28, 2020

Thanks - this is pretty non-critical because on the failure cases the broker immediately closes. It's nice to tidy up anyway so I've done that.

@ralight ralight closed this as completed Jan 28, 2020
@ralight ralight added this to the 1.6.9 milestone Jan 28, 2020
ralight added a commit that referenced this issue Jan 28, 2020
@ralight
Satisfy valgrind when exiting on error.
812c063 
This is when due to not being able to open a listening socket, solved by
calling freeaddrinfo in the error cases.

Closes #1565. Thanks to back1127.
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.9
Development

No branches or pull requests
2 participants
@ralight @back1127