Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto_pub -l sends null messages on empty line #1474

Closed
majekw opened this issue Oct 24, 2019 · 3 comments
Closed

mosquitto_pub -l sends null messages on empty line #1474

majekw opened this issue Oct 24, 2019 · 3 comments
Milestone

Comments

@majekw
Copy link
Contributor

majekw commented Oct 24, 2019

According to man page, empty line on stdin input should be ignored, but right now they send null messages.
It could be great if man and real life behavior would be consistent.

I could prepare fix for this (man page or code). If code needs to fixed it would be easier to work on top of #1473 :-)

@ralight
Copy link
Contributor

ralight commented Nov 7, 2019

My feeling with this is that sending an empty message is the correct thing to do, so the man page should be updated. Would you agree?

@ralight ralight added this to the 1.6.8 milestone Nov 7, 2019
@majekw
Copy link
Contributor Author

majekw commented Nov 7, 2019

In my opinion sending null is better than silently dropping empty message. So, man page update should be enough to fix this.

ralight added a commit that referenced this issue Nov 7, 2019
Blank lines are sent as empty messages.

Closes #1474. Thanks to majekw.
@ralight
Copy link
Contributor

ralight commented Nov 7, 2019

Great, thanks.

@ralight ralight closed this as completed Nov 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants