Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rr_client redefines 'cfg' #1453

Closed
jveber opened this issue Oct 9, 2019 · 1 comment
Closed

rr_client redefines 'cfg' #1453

jveber opened this issue Oct 9, 2019 · 1 comment
Milestone
1.6.8

Comments

@jveber
Copy link

jveber commented Oct 9, 2019

rr_client.c - "struct mosq_config cfg" (line 50) is already defined in pub_shared.c (line 41)
please add "extern" keyword infront of definition rr_client.c (line 50) to avoid this redefiniton and undefined behavior.
ralight added a commit that referenced this issue Oct 9, 2019
@ralight
Fix duplicate cfg definition in rr_client.
8a4ae28 
Closes #1453. Thanks to jveber.
@ralight
Copy link
Contributor

ralight commented Oct 9, 2019

So it does. Well spotted and thanks for the report. That's now fixed in the fixes branch.

@ralight ralight added this to the 1.6.8 milestone Oct 31, 2019
@ralight ralight closed this as completed Oct 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.8
Development

No branches or pull requests
2 participants
@ralight @jveber