Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosquitto_string_option returns 3 for MOSQ_OPT_TLS_KEYFORM with proper input #1360

Closed
MikeDombo opened this issue Jul 30, 2019 · 2 comments
Closed

mosquitto_string_option returns 3 for MOSQ_OPT_TLS_KEYFORM with proper input #1360

MikeDombo opened this issue Jul 30, 2019 · 2 comments
Labels
Component: libmosquitto Type: Bug
Milestone
1.6.4

Comments

@MikeDombo
Copy link

mosquitto_string_option returns 3 which is MOSQ_ERR_INVAL when setting MOSQ_OPT_TLS_KEYFORM because the success cases don't return success, they just fallthrough and return the default.
ralight added a commit that referenced this issue Jul 30, 2019
@ralight
Fix mosquitto_string_option(, MOSQ_OPT_TLS_KEYFORM, ) return value
f21ccc3 
`mosquitto_string_option(mosq, MOSQ_OPT_TLS_KEYFORM, ...)` was incorrectly
returning `MOSQ_ERR_INVAL` with valid input. This has been fixed.

Closes #1360. Thanks to Michael Dombrowski.
@ralight
Copy link
Contributor

ralight commented Jul 30, 2019

Thanks, that should be fixed now.

@ralight ralight added this to the 1.6.4 milestone Jul 30, 2019
@MikeDombo
Copy link
Author

Thanks for the quick fix!

vankxr pushed a commit to vankxr/mosquitto that referenced this issue Aug 9, 2019
@ralight @vankxr
Fix mosquitto_string_option(, MOSQ_OPT_TLS_KEYFORM, ) return value
3f85ae5 
`mosquitto_string_option(mosq, MOSQ_OPT_TLS_KEYFORM, ...)` was incorrectly
returning `MOSQ_ERR_INVAL` with valid input. This has been fixed.

Closes eclipse#1360. Thanks to Michael Dombrowski.
ralight added a commit that referenced this issue Sep 18, 2019
@ralight
Fix mosquitto_string_option(, MOSQ_OPT_TLS_KEYFORM, ) return value
36532fa 
`mosquitto_string_option(mosq, MOSQ_OPT_TLS_KEYFORM, ...)` was incorrectly
returning `MOSQ_ERR_INVAL` with valid input. This has been fixed.

Closes #1360. Thanks to Michael Dombrowski.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: libmosquitto Type: Bug
Projects
None yet
Milestone
1.6.4
Development

No branches or pull requests
2 participants
@ralight @MikeDombo