Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosquitto clients no longer exit non-zero if access is denied #1354

Closed
benbarbour opened this issue Jul 19, 2019 · 1 comment
Closed

mosquitto clients no longer exit non-zero if access is denied #1354

benbarbour opened this issue Jul 19, 2019 · 1 comment
Labels
Component: mosquitto-clients Type: Bug
Milestone
1.6.4

Comments

@benbarbour
Copy link

After upgrading to 1.6.3 using an invalid password still prints a message to standard error, but not longer exits non-zero. This broke a few of our scripts, and I think it makes sense to maintain the old behaviour.
ralight added a commit that referenced this issue Jul 24, 2019
@ralight
Fix error codes not being returned when mosquitto_pub exits.
b807dae 
Closes #1354. Thanks to Ben Barbour.
@ralight
Copy link
Contributor

ralight commented Jul 24, 2019

I agree, the old behaviour should be kept. Sorry about the regression, it was unintentional. I've pushed a fix.

@ralight ralight added this to the 1.6.4 milestone Jul 24, 2019
@ralight ralight closed this as completed Aug 1, 2019
vankxr pushed a commit to vankxr/mosquitto that referenced this issue Aug 9, 2019
@ralight @vankxr
Fix error codes not being returned when mosquitto_pub exits.
11a2b90 
Closes eclipse#1354. Thanks to Ben Barbour.
ralight added a commit that referenced this issue Sep 18, 2019
@ralight
Fix error codes not being returned when mosquitto_pub exits.
a4d4221 
Closes #1354. Thanks to Ben Barbour.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: mosquitto-clients Type: Bug
Projects
None yet
Milestone
1.6.4
Development

No branches or pull requests
2 participants
@ralight @benbarbour