Regression: Zero length input using --stdin-line not handled properly

[marwatk]

Looks like #676 has cropped back up. It works fine with 1.5.3 but not 1.6.2:

root@softwareradio:~# mosquitto_pub --help | head -2
mosquitto_pub is a simple mqtt client that will publish a message on a single topic and exit.
mosquitto_pub version 1.6.2 running on libmosquitto 1.6.2.

root@softwareradio:~# dd if=/dev/zero count=0 | mosquitto_pub --stdin-line --topic sensors/433_raw --host <redacted> --port 1883 -d
0+0 records in
0+0 records out
0 bytes copied, 0.00390834 s, 0.0 kB/s
Client mosq/sCYUoZnobu8Y2A3y5a sending CONNECT
Client mosq/sCYUoZnobu8Y2A3y5a received CONNACK (0)

Here's with 1.5.3:

0+0 records in
0+0 records out
0 bytes copied, 0.0366094 s, 0.0 kB/s
Client mosqpub|11313-softwarer sending CONNECT
Client mosqpub|11313-softwarer received CONNACK (0)
Client mosqpub|11313-softwarer sending DISCONNECT

[ralight]

Are you able to check with the fixes branch? There was a -l related fix there already. I'm on holiday right now so it's tricky to check myself at the moment.

[ralight]

A fix is in the fixes branch now, I'm not entirely sure about other behaviour though.

[marwatk]

Sorry, must have missed the first email. Is there anything you'd still like tested?

…

On Thu, Jun 6, 2019, 4:22 PM Roger Light ***@***.***> wrote: A fix is in the fixes branch now, I'm not entirely sure about other behaviour though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1302?email_source=notifications&email_token=AA2YJDNRFLLODDA2ZCWZ3NLPZGEZDA5CNFSM4HSDSM6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXEKQVY#issuecomment-499689559>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2YJDM7JEDVOJYKSJDZONDPZGEZDANCNFSM4HSDSM6A> .

[ralight]

The fix is related to a previous commit that was fixing some -l messages not being sent at QoS > 0. I think it was just the final message not being sent. It all looks fine to me, but if you are able to confirm you get the behaviour you expect it would be nice to hear.