Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple tls_version versions #1258

Closed
daenney opened this issue May 3, 2019 · 2 comments
Closed

Allow multiple tls_version versions #1258

daenney opened this issue May 3, 2019 · 2 comments
Milestone
2.0

Comments

@daenney
Copy link

daenney commented May 3, 2019

I'd like to be able to enable both TLSv1.3 and TLSv1.2 but disable TLSv1.1. I tried tls_version tlsv1.3 tlsv1.2 but that's not accepted. It seems I'm only able to enable one TLS version?
@ralight
Copy link
Contributor

ralight commented May 22, 2019

You're right, at the moment it's either all or nothing. I'll see about changing that.

@ralight ralight added this to the 1.7 milestone May 22, 2019
@ralight ralight modified the milestones: 1.7, 2.0 Oct 27, 2020
ralight added a commit that referenced this issue Oct 27, 2020
@ralight
Change tls_version option behaviour.
abbeb44 
The `tls_version` option now defines the *minimum* TLS protocol version to
be used, rather than the exact version.

Closes #1258. Thanks to Daniele Sluijters.
@ralight
Copy link
Contributor

ralight commented Oct 27, 2020

The change in behaviour doesn't match exactly what you asked for, but gives the end result that you want. I think specifying a minimum version is a better choice here anyway.

@daenney daenney closed this as completed Nov 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@ralight @daenney