Broken comparison of boolean values in CMakeLists.txt

[mojca]

The boolean options in CMake should not be compared with STREQUAL, but as boolean values instead, so that even -DUSE_LIBWRAP=yes would work, for example, see the CMake documentation.

For example, the following

if (${USE_LIBWRAP} STREQUAL ON)
	set (MOSQ_LIBS ${MOSQ_LIBS} wrap)
	add_definitions("-DWITH_WRAP")
endif (${USE_LIBWRAP} STREQUAL ON)

would probably better be written as

if (USE_LIBWRAP)
	set (MOSQ_LIBS ${MOSQ_LIBS} wrap)
	add_definitions("-DWITH_WRAP")
endif (USE_LIBWRAP)

[slewsys]

The problem is aggravated by the fact that the Build Dependencies section of Mosquitto's readme.md explicitly uses "yes" and "no" boolean values, contrary to the tests in CMakeLists.txt as per Mojca's comment.

[mojca]

Of course those examples are for the regular Makefiles, not for CMake. The only way to kind of clarify that would be to repeat the same options as they were supposed to be used in CMake. I admit that I was never aware of the validity of yes/no until @slewsys pointed it out.

[ralight]

Thanks for the report and example. It's also nice to have a change which brings a functional improvement and makes it more readable all at the same time.

Closed in 8fce261 , which will be part of 1.5.6 soon-ish.

[mojca]

Thank you very much for the super quick fix.