Fix mosquitto_publish*() no longer returning MOSQ_ERR_NO_CONN.

This was always returning success when the client was not connected. Closes #1725. Thanks to BOTorioN.
eclipse · Jul 15, 2020 · d371b3c · d371b3c
1 parent b4e0dfa
commit d371b3c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -14,6 +14,8 @@ Broker:
 
 Client library:
 - Improved documentation around connect callback return codes. Close #1730.
+- Fix `mosquitto_publish*()` no longer returning `MOSQ_ERR_NO_CONN` when not
+ connected. Closes #1725.
 
 
 1.6.10 - 2020-05-25

diff --git a/lib/actions.c b/lib/actions.c
@@ -151,9 +151,9 @@ int mosquitto_publish_v5(struct mosquitto *mosq, int *mid, const char *topic, in
 
  pthread_mutex_lock(&mosq->msgs_out.mutex);
  message->state = mosq_ms_invalid;
- message__queue(mosq, message, mosq_md_out);
+ rc = message__queue(mosq, message, mosq_md_out);
  pthread_mutex_unlock(&mosq->msgs_out.mutex);
- return MOSQ_ERR_SUCCESS;
+ return rc;
  }
 }