Fix use after free (unreleased)

eclipse · Nov 6, 2020 · c5ba597 · c5ba597
1 parent 255ae24
commit c5ba597
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/database.c b/src/database.c
@@ -1018,10 +1018,10 @@ static int db__message_write_inflight_out_single(struct mosquitto_db *db, struct
  }
  if(now > msg->store->message_expiry_time){
  /* Message is expired, must not send. */
- db__message_remove(db, &context->msgs_out, msg);
  if(msg->direction == mosq_md_out && msg->qos > 0){
  util__increment_send_quota(context);
  }
+ db__message_remove(db, &context->msgs_out, msg);
  return MOSQ_ERR_SUCCESS;
  }else{
  expiry_interval = (uint32_t)(msg->store->message_expiry_time - now);