Remove redundant initialization in clients

the `memset(&cfg, 0, sizeof(struct mosq_config));` already exsits in `client_config_load()`'s `init_config()` function call. So calling it in main function is totally unnecessary. Signed-off-by: YangHau <[email protected]>
eclipse · Sep 17, 2019 · 203c0ab · 203c0ab
1 parent 8c1d380
commit 203c0ab
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/client/pub_client.c b/client/pub_client.c
@@ -443,7 +443,6 @@ int main(int argc, char *argv[])
 
  if(pub_shared_init()) return 1;
 
- memset(&cfg, 0, sizeof(struct mosq_config));
  rc = client_config_load(&cfg, CLIENT_PUB, argc, argv);
  if(rc){
  if(rc == 2){

diff --git a/client/rr_client.c b/client/rr_client.c
@@ -252,8 +252,6 @@ int main(int argc, char *argv[])
 #ifndef WIN32
  struct sigaction sigact;
 #endif
-
- memset(&cfg, 0, sizeof(struct mosq_config));
 
  mosquitto_lib_init();
 

diff --git a/client/sub_client.c b/client/sub_client.c
@@ -278,8 +278,6 @@ int main(int argc, char *argv[])
 #ifndef WIN32
  struct sigaction sigact;
 #endif
-
- memset(&cfg, 0, sizeof(struct mosq_config));
 
  mosquitto_lib_init();