renamed adore_cli services to accommodate the stricter docker compose… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion tag from compose files, renamed compose services for plotlabserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the stricter static checks intruduced in docker compose version >=
2.24.6with the issue is detailed in: #69This PR introduces container name changes for the
adore_cli,libadoreandplotlabserverservices and removes thedepends_onandversiontag and from the docker compose file due to deprecation and stricter static checksThe
adore_cli,plotlabserver, andapt_cacher_ng_dockersubmodules were updated with the PR.The CI action successfully passed with the corresponding commit for this PR:
https://github.com/akoerner1/adore/actions/runs/8612759571
Before accepting this PR please do a clean clone, build and run of the baseline_test scenario.