Support snappy compression #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Aug 5, 2024
vertx-core/src/main/java/io/vertx/core/http/impl/Http1xClientConnection.java
Show resolved
Hide resolved
vietj
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Documentation should be updated https://vertx.io/docs/vertx-core/java/#_handling_compressed_body
|
For the docs look in the .adoc file in the project and search for brotli |
vietj
reviewed
Aug 7, 2024
|
thank you @lucamolteni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Support snappy as a compression mechanism
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Similar to https://github.com/eclipse-vertx/vert.x/pull/5176/files but Snappy support is already inside netty so I don't need to include any other dependencies
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines