Bring JPMS to vertx-core #5244
Merged
Bring JPMS to vertx-core #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
jpms-support
branch
6 times, most recently
from
73d0711
to
a873cb4
Compare
The logging part of vertx-core has been extracted into its own module since which makes it easier to test with modules. The most complex changes are actually in the vertx-core tests since some tests behave differently with a module and the vertx tests had split packages with the vertx core classes which needs to be avoided for proper testing.
tsegismont
added a commit
to eclipse-vertx/vertx-http-proxy
that referenced
this pull request
Jun 27, 2024
See eclipse-vertx/vert.x#5244 Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring support JPMS to vertx-core.
The exported packages are the public API of Vert.x as well as the internal API of Vert.x, the implementation of Vert.x remains encapsulated.
Vert.x as a library remains focused first on the classpath usage, however this aims to support it equally well in a applications.
The internal logging and implementation of vertx has been extracted into its own module since which makes it easier to test with modules and it actually does not interact much with the rest of the vertx core. Also this prevents default exposure of the logging packages to applications that don't need it. Note that does not prevent exposure, any module can depend on the io.vertx.core.ogging module but this module is not transitively exposed by the io.vertx.core module.
A lot of changes has been done in the tests since some tests behave differently with a module and the vertx tests had split packages with the vertx core classes which needs to be avoided for proper testing.