Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessMode.CONCURRENT's VarHandle should be a constant (Fixes #5216) #5217

Merged

Conversation

franz1981
Copy link
Contributor

@franz1981 franz1981 commented May 30, 2024

This is fixing #5216

Benchmarks results show the improvement (magnified by clearly the "nano"-benchmarking effect):

Benchmark                   Mode  Cnt  Score   Error  Units
AccessModeBenchmark.getNew  avgt   20  0.835 ± 0.008  ns/op
AccessModeBenchmark.getOld  avgt   20  6.253 ± 0.065  ns/op
AccessModeBenchmark.putNew  avgt   20  1.921 ± 0.012  ns/op
AccessModeBenchmark.putOld  avgt   20  8.474 ± 0.211  ns/op

@vietj vietj merged commit d262280 into eclipse-vertx:master May 30, 2024
7 checks passed
@vietj vietj added this to the 5.0.0 milestone May 30, 2024
@franz1981 franz1981 deleted the master_trusted_array_varhandle branch May 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants