Support duplicated context duplication #5215
Conversation
|
@franz1981 @cescoffier please have a look |
|
This can be related (and better used at) quarkusio/quarkus#40725 can you checkout my branch there and show how the changes there will translate with the new API, bud? I'm travelling, but I would like, before it got merged, to make sure the semantic and behaviours won't change too much and instead we save some code by leveraging this new feature (which is super cool!) |
|
for now this is a tentative PR, we can discuss next week @franz1981 I think |
|
Yep, let's sync once I'm back, thanks @vietj 🙏 |
|
|
||
| final int index; | ||
| final Class<T> type; | ||
| final Function<T, ? extends T> duplicator; |
| @@ -164,7 +164,28 @@ public boolean isWorkerContext() { | |||
|
|
|||
| @Override | |||
| public ContextInternal duplicate() { | |||
| return new DuplicatedContext(delegate, locals.length == 0 ? VertxImpl.EMPTY_CONTEXT_LOCALS : new Object[locals.length]); | |||
| Object[] localsDuplicate = locals.length == 0 ? VertxImpl.EMPTY_CONTEXT_LOCALS : locals.clone(); | |||
| ContextLocal<?>[] contextLocals = ((VertxImpl) delegate.owner()).contextLocals; | |||
There was a problem hiding this comment.
Given that the CHM is forcibly at index 0 why we cannot just treat it already separately without having a specific interface to perform the duplication?
This will make the tight loop here to be replaced by an optimized Arrays's batch copy (using Arrays.copyOf-like methods) + a "special" reset of the 0 key - which is the CHM one
… actual locals is not defined. This update the duplicated context duplication by doing a copy of each local in the duplicated duplicate. This introduce a duplicator for each local that is responsible for copying the object when it is not null.
ace4b39
to
dc2f1fb
Compare
Duplicating a duplicated context is supported but the semantic of the actual locals is not defined.
This update the duplicated context duplication by doing a copy of each local in the duplicated duplicate. This introduce a duplicator for each local that is responsible for copying the object when it is not null.