-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 5163 configurable socket keepalive interval #5183
base: 4.x
Are you sure you want to change the base?
Feature 5163 configurable socket keepalive interval #5183
Conversation
…conds, tcpKeepAliveIntervalSeconds
* 4.x: Add option for whether semicolon is treated as normal character or not HTTP/1 server request does execute twice the delivery of the content to the handler. Set version to 4.5.8-SNAPSHOT Releasing 4.5.7 Native image metadata should be in a vertx jar with the native-image classifier instead of the default jar artifact. A Vertx uses cached reflection to build the virtual thread factory in order to remain compatible with Java 8. When running in a native image Vert.x will assume that the runtime might not have virtual thread incorrectly. Fix a regression in HttpServerRequest#isExpectMultipart due to the cleanup of the form.
bootstrap.childOption(EpollChannelOption.TCP_KEEPIDLE, options.getTcpKeepAliveIdleSeconds()); | ||
} | ||
if (options.isTcpKeepAlive() && options.getTcpKeepAliveCount() != -1) { | ||
bootstrap.childOption(EpollChannelOption.TCP_KEEPCNT, options.getTcpKeepAliveIdleSeconds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be getTcpKeepAliveCount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
bootstrap.childOption(EpollChannelOption.TCP_KEEPCNT, options.getTcpKeepAliveIdleSeconds()); | ||
} | ||
if (options.isTcpKeepAlive() && options.getTcpKeepAliveIntervalSeconds() != -1) { | ||
bootstrap.childOption(EpollChannelOption.TCP_KEEPINTVL, options.getTcpKeepAliveIdleSeconds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be getTcpKeepAliveIntervalSeconds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
…terval * 4.x: The JacksonCodec implementation of toString/toBuffer lacks of efficiency compared to the DatabindCodec implementation which uses the buffer recyler of Jackson. The code to compare two numbers in json object/array does not correctly compare BigInteger/BigDecimal values. Fix a few bugs related to non event-loop thread writes. Set version to 4.5.9-SNAPSHOT Releasing 4.5.8 @GenIgnore ReadStream#collect The AsyncFile implementation will continue to read the file when the handler is set to null, instead it should stop reading. In addition report async file exception to the context when no exception handler is set. Add a general purpose collecting method to ReadStream to facilitate the reduction of streams. The collecting method is a default method. Deprecate vertx.disableTCCL Deprecate vertx.disableHttpHeadersValidation The Http1xServerConnection synchronize itself to guard the internal state of the request/response in progress. Update javadoc of DuplicatedContext as it's not maintain a seperated taskQueue anymore. Future expectation with HTTP response expectation. Fix benchmark Back port fix json object#equals method fails when comparing integers with floats (eclipse-vertx#5193) Fix InboundBuffer::pause & write performance Reduce synchronizations over conn
Feature according to: github.com/eclipse-vertx/vert.x/issues/5163