Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect HTTP server metrics report for non event-loop thread writes #5222

Closed
vietj opened this issue Jun 4, 2024 · 1 comment
Closed

Incorrect HTTP server metrics report for non event-loop thread writes #5222

vietj opened this issue Jun 4, 2024 · 1 comment
Assignees
@vietj
Labels
bug
Milestone
4.5.9

Comments

@vietj
Copy link
Member

vietj commented Jun 4, 2024 •
edited
Loading

The HTTP server incorrectly report metrics from non event-loop thread writes.

When writing from a non event-loop threads, HTTP/2 flush might happen earlier which triggers an incorrect report of metrics (reset instead of ended, invalid route report).
@vietj vietj added the bug label Jun 4, 2024
@vietj vietj added this to the 4.5.9 milestone Jun 4, 2024
vietj added a commit that referenced this issue Jun 4, 2024
@vietj
Fix a few bugs related to non event-loop thread writes.
480bdd6 
- Incorrect HTTP server metrics report for non event-loop thread writes #5222
- HTTP/2 push is not flushed when written from a non event-loop thread #5223
This was referenced Jun 4, 2024
Merged
Open
@vietj vietj self-assigned this Jun 4, 2024
vietj added a commit that referenced this issue Jun 4, 2024
@vietj
Fix a few bugs related to non event-loop thread writes.
aec1041 
- Incorrect HTTP server metrics report for non event-loop thread writes #5222
- HTTP/2 push is not flushed when written from a non event-loop thread #5223
@vietj vietj closed this as completed Jun 4, 2024
vietj added a commit that referenced this issue Jun 4, 2024
@vietj
Fix a few bugs related to non event-loop thread writes.
6a957f7 
- Incorrect HTTP server metrics report for non event-loop thread writes #5222
- HTTP/2 push is not flushed when written from a non event-loop thread #5223
@vietj vietj mentioned this issue Jun 4, 2024
Merged
vietj added a commit that referenced this issue Jun 4, 2024
@vietj
Fix a few bugs related to non event-loop thread writes.
fc3c4da 
- Incorrect HTTP server metrics report for non event-loop thread writes #5222
- HTTP/2 push is not flushed when written from a non event-loop thread #5223
@tsegismont
Copy link
Contributor

Thank you @vietj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vietj vietj

Labels
bug
Projects
None yet
Milestone
4.5.9
Development

No branches or pull requests
2 participants
@vietj @tsegismont