Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadLocal::remove performance impacts #4749

Closed
franz1981 opened this issue Jun 21, 2023 · 0 comments · Fixed by #5092
Closed

ThreadLocal::remove performance impacts #4749

franz1981 opened this issue Jun 21, 2023 · 0 comments · Fixed by #5092
Labels
bug

Comments

@franz1981
Copy link
Contributor

franz1981 commented Jun 21, 2023 •
edited
Loading

vert.x/src/main/java/io/vertx/core/net/impl/pool/CombinerExecutor.java

Line 60 in 04d4d65

current.remove();
introduced to solve #4583 is not performant (for our use cases), see
smallrye/smallrye-context-propagation#424 (comment)

A different mechanism or just using FastThreadLocal's (to ve verified if they have the same impact) would solve it.
@franz1981 franz1981 added the bug label Jun 21, 2023
@franz1981 franz1981 changed the title ThreadLocal::remove can cause scalability impacts ThreadLocal::remove performance impacts Jun 21, 2023
franz1981 added a commit to franz1981/vert.x that referenced this issue Jun 21, 2023
@franz1981
Use fast thread local and fix GC nepotism (Fixes eclipse-vertx#4749)
db88d61
franz1981 added a commit to franz1981/vert.x that referenced this issue Jun 21, 2023
@franz1981
Use fast thread local and fix GC nepotism (Fixes eclipse-vertx#4749)
15f7368
@vietj vietj closed this as completed in 99bc0da Jun 23, 2023
franz1981 added a commit to franz1981/vert.x that referenced this issue Jun 23, 2023
@franz1981
Use fast thread local and fix GC nepotism (Fixes eclipse-vertx#4749) (e…
3df735b 
…clipse-vertx#4750)

* Use fast thread local and fix GC nepotism (Fixes eclipse-vertx#4749)
* Replace order of reentrant task's merge
@franz1981 franz1981 mentioned this issue Jun 23, 2023
Merged
vietj pushed a commit that referenced this issue Jun 27, 2023
@franz1981 @vietj
Use fast thread local and fix GC nepotism (Fixes #4749) (#4750)
f15cf1c 
* Use fast thread local and fix GC nepotism (Fixes #4749)
* Replace order of reentrant task's merge
@bolbat bolbat mentioned this issue Jan 25, 2024
Closed
@cescoffier cescoffier mentioned this issue Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix File resolver when classloader provides URLs for directories cescoffier/vert.x
1 participant
@franz1981