Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12475: Debug toobar not showing current launch configuration on startup #12480

Merged
merged 1 commit into from
May 23, 2023

Conversation

pchuong
Copy link
Contributor

@pchuong pchuong commented May 2, 2023

What it does

Closes: #12475

The pull-request fixes an issue where the last debug launch configuration was not reflected in the UI on startup, and instead would always show the first configuration in the list. With this update, the debug launch configuration is persisted similarly to VS Code.

How to test

  1. start the application
  2. select a debug launch configuration in the debug-view other than the first configuration
  3. reload the application
  4. confirm that the launch configuration is persisted

Review checklist

Reminder for reviewers

@msujew msujew added debug issues that related to debug functionality ui/ux issues related to user interface / user experience labels May 2, 2023
@msujew
Copy link
Member

msujew commented May 2, 2023

@pchuong Thanks for the contribution! Can you please give the PR a more descriptive title?

@pchuong pchuong changed the title https://github.com/eclipse-theia/theia/issues/12475 Fixed #12480: Debug tooblar not showing current launch configuration on startup May 2, 2023
@pchuong
Copy link
Contributor Author

pchuong commented May 2, 2023

Hi @msujew. It is updated.

@pchuong pchuong changed the title Fixed #12480: Debug tooblar not showing current launch configuration on startup Fixed #12480: Debug toobar not showing current launch configuration on startup May 2, 2023
@pchuong pchuong changed the title Fixed #12480: Debug toobar not showing current launch configuration on startup Fixed #12475: Debug toobar not showing current launch configuration on startup May 2, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 👍
I can confirm that the changes successfully fix the issue, and the changes look good to me.

@msujew
Copy link
Member

msujew commented May 23, 2023

@vince-fugnitto Do you want to merge this before the release?

@vince-fugnitto vince-fugnitto merged commit 782260e into eclipse-theia:master May 23, 2023
@vince-fugnitto vince-fugnitto added this to the 1.38.0 milestone May 25, 2023
@pchuong pchuong deleted the pchuong/issue-12475 branch September 6, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug toolbar does not render the current debug launch configuration on startup
3 participants