Fix resolution of package configuration provider secrets #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
requested review from
bs-ondem,
MarcelBochtler,
nnobelis,
oheger-bosch and
sschuberth
as code owners
mnonnenmacher
force-pushed
the
plugin-secret-resolution
branch
from
1e7609c
to
6e90a49
Compare
sschuberth
previously approved these changes
Jul 5, 2024
oheger-bosch
reviewed
Jul 5, 2024
workers/common/src/main/kotlin/common/context/WorkerContextImpl.kt
Outdated
Show resolved
Hide resolved
mnonnenmacher
force-pushed
the
plugin-secret-resolution
branch
from
6e90a49
to
0521f9a
Compare
mnonnenmacher
force-pushed
the
plugin-secret-resolution
branch
from
0521f9a
to
8d7db1b
Compare
Rename `resolveConfigSecrets` to `resolvePluginConfigSecrets` to make the purpose of the function clearer and to avoid a conflict with a function added in the next commit. Signed-off-by: Martin Nonnenmacher <[email protected]>
The tests in the container test the `resolvePluginConfigSecrets` function, not the `resolveConfigFiles` function. Signed-off-by: Martin Nonnenmacher <[email protected]>
Signed-off-by: Martin Nonnenmacher <[email protected]>
Add a helper function to resolve all secrets in a list of `ProviderPluginConfiguration`s. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
plugin-secret-resolution
branch
from
8d7db1b
to
89c151c
Compare
Resolve the secrets in the configurations of package configuration providers from the configured secret storage, instead of using the secret values directly. Fixes eclipse-apoapsis#611. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
plugin-secret-resolution
branch
from
89c151c
to
f02100d
Compare
Resolve the secrets in the configurations of package configuration providers from the configured secret storage, instead of using the secret values directly. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
plugin-secret-resolution
branch
from
f02100d
to
419a35c
Compare
sschuberth
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.
Note that a similar fix for package curation providers will be done in a separate PR.