refactor(vault): Remove an unneeded runBlocking call
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit message nits:
|
a8dabdf
to
aa97733
Compare
mnonnenmacher
requested changes
Jul 2, 2024
Rework the token handling to not fetch a token initially, but deal with a missing token during request execution. While this makes the logic slightly more complex, it has the benefit that during creation of a `VaultSecretsProvider` instance no request is sent, and the `runBlocking` call to fetch the initial token can be dropped. Signed-off-by: Oliver Heger <[email protected]>
aa97733
to
bc3fcea
Compare
mnonnenmacher
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the token handling to not fetch a token initially, but deal with a missing token during request execution. While this slightly makes the logic more complex, it has the benefits that during creation of a
VaultSecretsProviderinstance no request is sent, and therunBlockingcall to fetch the initial token can be dropped.