feat(ui): Increase the limits in API requests #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code is good, but there's a commit-lint error that I can't spot by eye. |
The problem was that commitlint treats every line that contains an issue reference as a footer. Not sure if that can be changed. |
mmurto
previously requested changes
Jun 19, 2024
| @@ -86,6 +86,7 @@ const OrganizationComponent = () => { | |||
| queryFn: async () => | |||
| await ProductsService.getOrganizationProducts({ | |||
| organizationId: Number.parseInt(params.orgId), | |||
| limit: 1000, | |||
There was a problem hiding this comment.
Actually this should be adjusted, or more specifically the limit should be added here as well, and the same is true for other pages. This way loader uses the same query as the query inside the component.
Not related to this PR, but this should be refactored to use queryOptions as shown here to not require repetition of the query options.
There was a problem hiding this comment.
The limit should be set for all queries now.
Increase the limits when requesting list of organizations, products, repositories, and runs from the default 20 to 1000. This mitigates the issue that not all entities can be accessed from the UI until pagination is implemented [1]. [1]: eclipse-apoapsis#453 Signed-off-by: Martin Nonnenmacher <[email protected]>
wkl3nk
approved these changes
Jun 21, 2024
sschuberth
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the limits when requesting list of organizations, products, repositories, and runs from the default 20 to 1000.
This mitigates the issue that not all entities can be accessed from the UI until #453 is implemented.