Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the notifier job configuration #618

Closed
mnonnenmacher opened this issue Jul 5, 2024 · 4 comments · Fixed by #662
Closed

Support the notifier job configuration #618

mnonnenmacher opened this issue Jul 5, 2024 · 4 comments · Fixed by #662
Assignees
Labels
enhancement New feature or request ui Issues related to the UI.

Comments

@mnonnenmacher
Copy link
Contributor

Add support for the notifier job configuration to the form to create a new ORT run. Also show the notifier job configuration in the run details.

@mnonnenmacher mnonnenmacher added enhancement New feature or request ui Issues related to the UI. labels Jul 5, 2024
@Etsija
Copy link
Contributor

Etsija commented Jul 8, 2024

Can I ask you about the username and password fields of Notifier configuration: are they really not secrets; so they are exposed in the UI?

    "notifier": {
      "notifierRules": "reporter.notifications.kts",
      "resolutionsFile": "resolutions.yml",
      "mail": {
        "recipientAddresses": [
          "[email protected]",
          "[email protected]"
        ],
        "mailServerConfiguration": {
          "hostName": "smtp.example.com",
          "port": 587,
          "username": "user",
          "password": "password",
          "useSsl": true,
          "fromAddress": "[email protected]"
        }
      },
      "jira": {
        "jiraRestClientConfiguration": {
          "serverUrl": "https://jira.example.com",
          "username": "user",
          "password": "password"
        }
      }
    },

@Etsija
Copy link
Contributor

Etsija commented Jul 8, 2024

ORT run creation form is already over 1000 lines long, so we're probably going to do some refactoring to it before adding new configurations.

@mnonnenmacher
Copy link
Contributor Author

Can I ask you about the username and password fields of Notifier configuration: are they really not secrets; so they are exposed in the UI?

Good point, they are treated as secrets, so the values are paths to secrets in the secret storage.

@Etsija
Copy link
Contributor

Etsija commented Jul 8, 2024

Can I ask you about the username and password fields of Notifier configuration: are they really not secrets; so they are exposed in the UI?

Good point, they are treated as secrets, so the values are paths to secrets in the secret storage.

Thanks, so it's safe for us to expose them in the form as ordinary text inputs.

@Etsija Etsija self-assigned this Jul 10, 2024
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Jul 11, 2024
Add support for the Notifier by adding an accordion component for it
to the run creation form. The Notifier is disabled by default.

Resolves eclipse-apoapsis#618.

Signed-off-by: Jyrki Keisala <[email protected]>
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Jul 11, 2024
Add support for the Notifier by adding an accordion component for it
to the run creation form. The Notifier is disabled by default.

Resolves eclipse-apoapsis#618.

Signed-off-by: Jyrki Keisala <[email protected]>
@Etsija Etsija linked a pull request Jul 11, 2024 that will close this issue
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Jul 11, 2024
Add support for the Notifier by adding an accordion component for it
to the run creation form. The Notifier is disabled by default.

Resolves eclipse-apoapsis#618.

Signed-off-by: Jyrki Keisala <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
Add support for the Notifier by adding an accordion component for it
to the run creation form. The Notifier is disabled by default.

Resolves #618.

Signed-off-by: Jyrki Keisala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Issues related to the UI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants