Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include number of entries for GET requests returning lists #599

Closed
Etsija opened this issue Jul 4, 2024 · 0 comments
Closed

Include number of entries for GET requests returning lists #599

Etsija opened this issue Jul 4, 2024 · 0 comments
Assignees
@mnonnenmacher
Labels
api Issues related to the API. enhancement New feature or request

Comments

@Etsija
Copy link
Contributor

Etsija commented Jul 4, 2024

To properly implement pagination in the UI #453, the corresponding GET requests need to return the total number of entries:

/api/v1/organizations
/api/v1/organizations/{organizationId}/products
/api/v1/products/{productId}/repositories
/api/v1/repositories/{repositoryId}/runs
/api/v1/organizations/{organizationId}/secrets
/api/v1/products/{productId}/secrets
/api/v1/repositories/{repositoryId}/secrets
/api/v1/organizations/{organizationId}/infrastructure-services
@Etsija Etsija changed the title Include number of entries for some GET requests Include number of entries for GET requests returning lists Jul 4, 2024
@sschuberth sschuberth added enhancement New feature or request api Issues related to the API. labels Jul 4, 2024
@mnonnenmacher mnonnenmacher self-assigned this Jul 5, 2024
mnonnenmacher added a commit to boschglobal/ort-server that referenced this issue Jul 11, 2024
@mnonnenmacher
feat(api): Migrate secret endpoints to PagedResponse2
29d3e3d 
Migrate the endpoints to provide the total entity count which is
required for pagination on the client.

Fixes eclipse-apoapsis#599.

Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher added a commit to boschglobal/ort-server that referenced this issue Jul 12, 2024
@mnonnenmacher
feat(api): Migrate secret endpoints to PagedResponse2
9a3475e 
Migrate the endpoints to provide the total entity count which is
required for pagination on the client.

Fixes eclipse-apoapsis#599.

Signed-off-by: Martin Nonnenmacher <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
@mnonnenmacher
feat(api): Migrate secret endpoints to PagedResponse2
b515bc8 
Migrate the endpoints to provide the total entity count which is
required for pagination on the client.

Fixes #599.

Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnonnenmacher mnonnenmacher

Labels
api Issues related to the API. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sschuberth @Etsija @mnonnenmacher