Unexpected config values for Scaleway Secret Provider

[haikoschol]

We are running ORT Server core in a Deployment in Scaleway Kubernetes. In order to use the Scaleway Secret Provider, we've set the following environment variables:

- name: SCW_API_VERSION
  value: "v1beta1"
- name: SCW_REGION
  value: "nl-ams"

A GET request to /api/v1/organizations/<id>/secrets fails with an internal server error and this message in the logs:

Caused by: com.typesafe.config.ConfigException$BadValue: hardcoded value: Invalid value at 'scwApiVersion': The enum class ScalewayApiVersion has no constant of the name 'v1beta1' (should be one of [V1_ALPHA1, V1_BETA1].)

The request succeeds with setting SCW_API_VERSION to V1_BETA1 and SCW_REGION to NETHERLANDS_AMSTERDAM.

Is this intended behavior? To me the code looks like v1beta1 and nl-ams should work. Or am I misunderstanding what @SerialName does?

cc @sschuberth

[sschuberth]

Is this intended behavior?

Yes. For type safety, I decided to require enum names instead of the untyped strings the raw REST API URL uses.

[sschuberth]

Or am I misunderstanding what @SerialName does?

Actually @SerialName does not play a role here because the code is not used to deserialize from the config file, but only to serialize for REST API usage. Instead, the ConfigManager code from here is relevant:

ort-server/secrets/scaleway/src/main/kotlin/ScalewayConfiguration.kt

Lines 61 to 62 in c355916

	apiVersion = configManager.getEnumOrDefault(NAME_OF_API_VERSION, DEFAULT_API_VERSION),
	region = configManager.getEnumOrDefault(NAME_OF_REGION, DEFAULT_REGION),

And that uses enums.

[haikoschol]

It would be nice to use the same strings as Scaleway does in their documentation. But if that results in a less helpful error message for incorrect values, it's probably not an improvement.

[sschuberth]

It would be nice to use the same strings as Scaleway does in their documentation.

Let me check if I could easily support both, enum names and raw strings as values.

[sschuberth]

@mnonnenmacher auto-close also did not work here. Could you contact EF support to check whether it's some issue with Otterdog?

[haikoschol]

It would be nice to use the same strings as Scaleway does in their documentation.

Let me check if I could easily support both, enum names and raw strings as values.

Works now. Thanks!

[mnonnenmacher]

@mnonnenmacher auto-close also did not work here. Could you contact EF support to check whether it's some issue with Otterdog?

This is really weird, I could not find any bug reports that the feature is broken for anyone else and it also seems that there is no option to configure or disable it somehow. But I will create an issue with EF eventually.