Use fewer magic numbers in code.

The length of the reserve and stats commands shouldn't be specified as magic numbers in code, they should use the definitions in beanstalkd.h.
echou · Sep 21, 2007 · fdca114 · fdca114
1 parent 5106780
commit fdca114
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/beanstalkd.c b/beanstalkd.c
@@ -190,7 +190,7 @@ do_cmd(conn c)
  break;
  case OP_RESERVE:
  /* don't allow trailing garbage */
- if (c->cmd_len != 9) return conn_close(c);
+ if (c->cmd_len != CSTRSZ(CMD_RESERVE) + 2) return conn_close(c);
 
  fprintf(stderr, "got reserve cmd: %s\n", c->cmd);
 
@@ -206,7 +206,7 @@ do_cmd(conn c)
  break;
  case OP_STATS:
  /* don't allow trailing garbage */
- if (c->cmd_len != 7) return conn_close(c);
+ if (c->cmd_len != CSTRSZ(CMD_STATS) + 2) return conn_close(c);
  warn("got stats command");
  conn_close(c);
  break;