Rename package #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes advantage of the new MediaItem.LiveConfiguration.Builder This change will always allocate a new LiveConfiguration.Builder and LiveConfiguration, but preserves the behaviour of keeping the same MediaItem instance if no values have changed. PiperOrigin-RevId: 397961427
The type is already UUID so there's no need to duplicate that info in the field name, and 'scheme' is a widely used term throughout both ExoPlayer and android.os.MediaDrm documentation. The old field remains deprecated for backwards compatibility. The MediaItem.DrmConfiguration.Builder#setUuid method is renamed directly (without deprecation) because it's not yet part of a released ExoPlayer version. PiperOrigin-RevId: 397961553
#minor-release PiperOrigin-RevId: 397976212
#minor-release PiperOrigin-RevId: 397976212
This change only calls setters if we need to override the existing value (or more specifically, set a value that's absent). PiperOrigin-RevId: 397979904
Both license and provisioning requests could be considered 'DRM requests', and these headers are only sent on license requests, so rename them to reflect that. The old field remains deprecated for backwards compatibility. PiperOrigin-RevId: 397980021
The MIME type is currently required to select a SubtitleDecoder implementation in the TextRenderer. Future changes might remove this requirement, so we pre-emptively mark the field as @nullable. The change in SingleSampleMediaSource ensures the track still maps to the TextRenderer, otherwise it shows up as unmapped. Passing null MIME type to MediaItem.Subtitle constructor now results in this from EventLogger: TextRenderer [ Group:0, adaptive_supported=N/A [ [ ] Track:0, id=null, mimeType=text/x-unknown, language=en, supported=NO_UNSUPPORTED_TYPE ] ] PiperOrigin-RevId: 398010809
These give some documentation-as-code for a clearkey integration with ExoPlayer. #exofixit PiperOrigin-RevId: 398017708
PiperOrigin-RevId: 398185843
PiperOrigin-RevId: 398200055
PiperOrigin-RevId: 398215071
Calling AudioManager.isOffloadedPlaybackSupported is available since API 29 only. PiperOrigin-RevId: 398229498
PiperOrigin-RevId: 398232186
PiperOrigin-RevId: 398247348
PiperOrigin-RevId: 398262695
Annotate build() with @InlineMe. I will update build() to return Player in a future change. PiperOrigin-RevId: 398446323
This brings in a fix that prevented documentation generation due to `<caption>` tags not being supported. PiperOrigin-RevId: 398475800
PiperOrigin-RevId: 398489644
This is currently required to make javadoc generation via Dackka succeed. PiperOrigin-RevId: 398518538
- If DownloadService is configured to run as a foreground service, it will remain started and in the foreground when downloads are waiting for requirements to be met, with a suitable "waiting for XYZ" message in the notification. This is necessary because new foreground service restrictions in Android 12 prevent to service from being restarted from the background. - Cases where requirements are not supported by the Scheduler will be handled in the same way, even on earlier versions of Android. So will cases where a Scheduler is not provided. - The Scheduler will still be used on earlier versions of Android where possible. Note: We could technically continue to use the old behavior on Android 12 in cases where the containing application still has a targetSdkVersion corresponding to Android 11 or earlier. However, in practice, there seems to be little value in doing this. PiperOrigin-RevId: 398720114
This aligns with other MediaItem.FooConfiguration class names and also more clearly represents that this class encapsulates information used for local playback that is lost when serializing MediaItem between processes. The old class and fields are kept (deprecated) for backwards compatibility. PiperOrigin-RevId: 398742708
temporary pulled out from the main cl to keep code small for review PiperOrigin-RevId: 398746806
PiperOrigin-RevId: 398749045
For Automotive devices, surround encodings can be supported via the passthrough path. Therefore, include automotive in the allowed device types in the isDirectPlaybackSupported checks. The automotive system feature is checked, rather then UI_MODE_TYPE_CAR, because the UI_MODE_TYPE_CAR can be force enabled via android.app.UiModeManager.enableCarMode(), whereas FEATURE_AUTOMOTIVE cannot be forced.
PiperOrigin-RevId: 399108998
PiperOrigin-RevId: 399139842
PiperOrigin-RevId: 399179751
PiperOrigin-RevId: 399206106
PiperOrigin-RevId: 406840246
PiperOrigin-RevId: 406849436
Accidental changes were introduced in http:https://google@c539243 PiperOrigin-RevId: 406858888
Where this introduced an inconsistency (e.g. assigning to something called `windowIndex`), I generally renamed the transitive closure of identifiers to maintain consistency (meaning this change is quite large). The exception is code that interacts with Timeline and Window directly, where sometimes I kept the 'window' nomenclature. #minor-release PiperOrigin-RevId: 407040052
#minor-release PiperOrigin-RevId: 407042882
The values returned by the framework method are equivalent to the local IntDef values. PiperOrigin-RevId: 407048748
#minor-release PiperOrigin-RevId: 407086818
These warnings are caused by the fact that this is a library and the lint check doesn't see any app using the library in a TV context. PiperOrigin-RevId: 407110725
#minor-release PiperOrigin-RevId: 407136922
PiperOrigin-RevId: 407162673
This refactoring is the basis to support RF64 (see Issue: google#9543). #minor-release PiperOrigin-RevId: 407301056
#minor-release PiperOrigin-RevId: 407305661
This cause the muxer to fail to stop on older devices/API levels. #minor-release PiperOrigin-RevId: 407309028
PiperOrigin-RevId: 407314385
PiperOrigin-RevId: 407333525
PiperOrigin-RevId: 407379522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.