Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev #59

Merged
merged 10 commits into from
Apr 9, 2020
Merged

dev #59

merged 10 commits into from
Apr 9, 2020

Conversation

DominiqueMakowski
Copy link
Member

No description provided.

strengejacke
strengejacke requested changes Mar 25, 2020
View reviewed changes
R/correlation.R Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #59 into master will increase coverage by 0.09%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   74.22%   74.32%   +0.09%     
==========================================
  Files          31       31              
  Lines         838      849      +11     
==========================================
+ Hits          622      631       +9     
- Misses        216      218       +2
Impacted Files Coverage Δ
R/print.easycormatrix.R 0.00% <0.00%> (ø)
R/cor_to_pcor.R 90.90% <100.00%> (+0.90%) ⬆️
R/correlation.R 78.30% <100.00%> (ø)
R/mahalanobis.R 100.00% <100.00%> (ø)
R/methods.easycorrelation.R 91.11% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72828a3...6c1cf94. Read the comment docs.

@DominiqueMakowski
Copy link
Member Author

and now it fails on mac 😠

@DominiqueMakowski
fix in pcor_to_cor
5626f8c 
close #61
@DominiqueMakowski
optional stars removal in summary
6c1cf94 
close #62
@DominiqueMakowski
n_param
464544d 
@mattansb we could pass this argument into the .cor_test_ internals, how to take it into account then? for instance in .cor_test_freq()?
@DominiqueMakowski
remove n_params, explain better this thins
c9570d4 
#63
@DominiqueMakowski
website + styler
158c62d
@DominiqueMakowski
Copy link
Member Author

Today is the 8th, as we said, should we submit to CRAN?

@DominiqueMakowski
Copy link
Member Author

submitted

@DominiqueMakowski
Copy link
Member Author

On its way to CRAN. Man that was fast!

@DominiqueMakowski DominiqueMakowski merged commit 2ffb100 into master Apr 9, 2020
@strengejacke
Copy link
Member

btw, I appreciate the news-file...

@DominiqueMakowski
Copy link
Member Author

It's such a piece of art that now I can't modify it 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strengejacke strengejacke strengejacke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DominiqueMakowski @codecov-io @strengejacke @mattansb