Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sampler give wrong result if no samples #964

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix: sampler give wrong result if no samples #964

merged 1 commit into from
Mar 31, 2023

Conversation

localvar
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 🎉

Comparison is base (f870f90) 73.05% compared to head (e9dc464) 73.25%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   73.05%   73.25%   +0.20%     
==========================================
  Files         134      135       +1     
  Lines       14866    15036     +170     
==========================================
+ Hits        10860    11015     +155     
- Misses       3380     3396      +16     
+ Partials      626      625       -1     
Impacted Files Coverage Δ
pkg/util/sampler/sampler.go 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci added this pull request to the merge queue Mar 31, 2023
Merged via the queue into easegress-io:main with commit 55a35d5 Mar 31, 2023
@localvar localvar deleted the fix-sampler-bug branch March 31, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants