export httpstat metrics to prometheus #963
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 73.05% 73.16% +0.11%
==========================================
Files 134 134
Lines 14866 14968 +102
==========================================
+ Hits 10860 10952 +92
- Misses 3380 3389 +9
- Partials 626 627 +1
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pkg/object/httpserver/runtime.go
Outdated
| httpserverLabels[:5]).MustCurryWith(commonLabels), | ||
| Min: prometheushelper.NewGauge( | ||
| "httpserver_min", | ||
| "the min of the http server", |
There was a problem hiding this comment.
please make a little improvement to this, as user can not know it is the minimal value of what.
please also fix the other similiar cases.
pkg/object/httpserver/runtime.go
Outdated
| httpserverLabels[:5]).MustCurryWith(commonLabels), | ||
| P25: prometheushelper.NewGauge( | ||
| "httpserver_p25", | ||
| "TP25: The http-request execution duration in milliseconds for 25% user of the http server.", |
There was a problem hiding this comment.
| "TP25: The http-request execution duration in milliseconds for 25% user of the http server.", | |
| "P25: The processing time for 25% of the requests, in milliseconds.", |
pkg/object/httpserver/runtime.go
Outdated
| Objectives: prometheushelper.DefaultObjectives(), | ||
| }, | ||
| httpserverLabels).MustCurryWith(commonLabels), | ||
| M1: prometheushelper.NewGauge( | ||
| "httpserver_m1", | ||
| "The http request executions per second (exponentially-weighted moving average) in last 1 minute", |
There was a problem hiding this comment.
| "The http request executions per second (exponentially-weighted moving average) in last 1 minute", | |
| "QPS (exponentially-weighted moving average) in last 1 minute", |
No description provided.