Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init object pool #940

Merged
merged 9 commits into from
Mar 16, 2023
Merged

init object pool #940

merged 9 commits into from
Mar 16, 2023

Conversation

sodaRyCN
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Patch coverage: 30.18% and project coverage change: -0.46 ⚠️

Comparison is base (0913eef) 73.37% compared to head (f88783c) 72.91%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   73.37%   72.91%   -0.46%     
==========================================
  Files         133      134       +1     
  Lines       14760    14866     +106     
==========================================
+ Hits        10830    10840      +10     
- Misses       3307     3400      +93     
- Partials      623      626       +3     
Impacted Files Coverage Δ
pkg/util/objectpool/objectpool.go 30.18% <30.18%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/util/objectpool/withlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withoutlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withoutlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withoutlock/objectpool.go Outdated Show resolved Hide resolved
@sodaRyCN
Copy link
Contributor Author

sodaRyCN commented Feb 27, 2023

keep which one objectpool or both

Copy link
Collaborator

@localvar localvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the lock-free version.

pkg/util/objectpool/withoutlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withoutlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/withoutlock/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/objectpool.go Outdated Show resolved Hide resolved
pkg/util/objectpool/objectpool.go Outdated Show resolved Hide resolved
@suchen-sci suchen-sci added this pull request to the merge queue Mar 16, 2023
Merged via the queue into easegress-io:main with commit f870f90 Mar 16, 2023
caoshengdong pushed a commit to caoshengdong/easegress that referenced this pull request Mar 19, 2023
* init object pool

* fix by bot adv

* fid and clean code

* cas

* fix: 1.remove pool base on sync.Mutex;2.expose fields of Spec;3.rename new pool func name

* use sync.Cond instead of spinlock

* remove unnecessary cond.Lock

* reactor code

* fix compile bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants