Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wasm apply-data command #939

Merged

Conversation

grootpiano
Copy link
Contributor

fixes #938 and some doc issues

Changes in wasm apply-data command:

  1. use YAMLVisitor instead of SpecVisitor
  2. use wasmApplyData handler instead of createObject handler

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 73.37% // Head: 73.38% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2a45eb1) compared to base (0913eef).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   73.37%   73.38%   +0.01%     
==========================================
  Files         133      133              
  Lines       14760    14760              
==========================================
+ Hits        10830    10832       +2     
+ Misses       3307     3306       -1     
+ Partials      623      622       -1     
Impacted Files Coverage Δ
pkg/filters/headerlookup/headerlookup.go 84.61% <0.00%> (-1.40%) ⬇️
pkg/object/mqttproxy/broker.go 73.87% <0.00%> (+0.15%) ⬆️
pkg/cluster/cluster.go 61.15% <0.00%> (+0.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci added this pull request to the merge queue Mar 3, 2023
Merged via the queue into easegress-io:main with commit 6408203 Mar 3, 2023
@grootpiano grootpiano deleted the fix/wasm-apply-data-command-938 branch March 3, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: wasm apply data command not worked
4 participants