Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wasm bug #937

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix wasm bug #937

merged 1 commit into from
Feb 23, 2023

Conversation

LokiWager
Copy link
Collaborator

  1. filter type is map[string]interface{} not map[interface{}]interface{}
  2. init response object
  3. call alloc function before reading wasm memory, because wasm memory maybe changes when calling alloc function.

1. filter type is map[string]interface{} not map[interface{}]interface{}
2. init response object
3. call alloc function before reading wasm memory, because wasm memory maybe changes when calling alloc function.
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 73.36% // Head: 73.29% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (137f09e) compared to base (c820407).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   73.36%   73.29%   -0.07%     
==========================================
  Files         133      133              
  Lines       14760    14760              
==========================================
- Hits        10828    10818      -10     
- Misses       3308     3320      +12     
+ Partials      624      622       -2     
Impacted Files Coverage Δ
pkg/object/mqttproxy/sessioncache.go 49.49% <0.00%> (-10.11%) ⬇️
pkg/filters/headerlookup/headerlookup.go 84.61% <0.00%> (-1.40%) ⬇️
pkg/object/mqttproxy/broker.go 73.25% <0.00%> (-0.63%) ⬇️
pkg/cluster/cluster.go 61.15% <0.00%> (+1.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci added this pull request to the merge queue Feb 23, 2023
Merged via the queue into easegress-io:main with commit 0913eef Feb 23, 2023
@LokiWager LokiWager deleted the fix_bug branch March 3, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants