Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RayId to HttpServer span #928

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

LokiWager
Copy link
Collaborator

Add RayId to HttpServer span when there is Cloudflare RayId header but no timestamp headers.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Base: 73.16% // Head: 73.22% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (b051409) compared to base (eec7d77).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   73.16%   73.22%   +0.05%     
==========================================
  Files         131      131              
  Lines       15007    15008       +1     
==========================================
+ Hits        10980    10989       +9     
+ Misses       3403     3397       -6     
+ Partials      624      622       -2     
Impacted Files Coverage Δ
pkg/tracing/cloudflare.go 90.00% <100.00%> (+0.34%) ⬆️
pkg/filters/headerlookup/headerlookup.go 84.61% <0.00%> (-1.40%) ⬇️
pkg/cluster/cluster.go 61.15% <0.00%> (+1.05%) ⬆️
pkg/filters/validator/basicauth.go 76.53% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci merged commit 37714a6 into easegress-io:main Feb 13, 2023
@LokiWager LokiWager deleted the rayid_span branch February 20, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants