Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #923 update cookbook examples and fix some typo #924

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

grootpiano
Copy link
Contributor

@grootpiano grootpiano commented Feb 6, 2023

fixes #923

I noticed that we already opened a PR #882 for updating docs.
So, which branch should I merge these changes into, megaease:main or localvar:minor-doc-fix?

@localvar
Copy link
Collaborator

localvar commented Feb 6, 2023

please use megaease:main, or your contribution will belong to me 😄, because localvar:minor-doc-fix is my PR .

@grootpiano
Copy link
Contributor Author

please use megaease:main, or your contribution will belong to me 😄, because localvar:minor-doc-fix is my PR .

That doesn't matter. We all Groot. 👀🌳

Current target branch is megaease:main, if I should make some updates, please let me know. ❤️

@grootpiano
Copy link
Contributor Author

It seems other cookbook examples don't have the same issue. This PR is ready for review. 🚀

@suchen-sci suchen-sci merged commit 4e4e504 into easegress-io:main Feb 9, 2023
@grootpiano grootpiano deleted the fix/update-doc-923 branch February 9, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Some cookbook examples are out-of-date.
4 participants