Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make code compile under Go v1.20 #922

Merged
merged 2 commits into from
Feb 3, 2023
Merged

make code compile under Go v1.20 #922

merged 2 commits into from
Feb 3, 2023

Conversation

localvar
Copy link
Collaborator

@localvar localvar commented Feb 3, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 73.11% // Head: 73.11% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9741878) compared to base (7c2c484).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   73.11%   73.11%   -0.01%     
==========================================
  Files         130      130              
  Lines       14969    14969              
==========================================
- Hits        10945    10944       -1     
- Misses       3404     3407       +3     
+ Partials      620      618       -2     
Impacted Files Coverage Δ
pkg/object/httpserver/runtime.go 68.50% <ø> (ø)
pkg/object/grpcserver/runtime.go 67.91% <0.00%> (-6.42%) ⬇️
pkg/filters/headerlookup/headerlookup.go 84.61% <0.00%> (-1.40%) ⬇️
pkg/filters/validator/basicauth.go 75.38% <0.00%> (+0.38%) ⬆️
pkg/cluster/cluster.go 62.21% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@localvar localvar merged commit 73d7dd3 into easegress-io:main Feb 3, 2023
@localvar localvar deleted the fix-compile-error branch February 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants