Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance access log #901

Merged
merged 7 commits into from
Jan 13, 2023
Merged

Enhance access log #901

merged 7 commits into from
Jan 13, 2023

Conversation

samanhappy
Copy link
Collaborator

Resolve #301, this PR is trying to enhance access log by

  • include request headers and response headers
  • make access log format configurable

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 75.89% // Head: 75.84% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (30e40ce) compared to base (5600a4b).
Patch coverage: 48.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   75.89%   75.84%   -0.06%     
==========================================
  Files         115      115              
  Lines       13464    13497      +33     
==========================================
+ Hits        10219    10237      +18     
- Misses       2668     2683      +15     
  Partials      577      577              
Impacted Files Coverage Δ
pkg/object/httpserver/spec.go 76.19% <ø> (ø)
pkg/object/httpserver/mux.go 77.60% <48.21%> (-3.29%) ⬇️
pkg/object/autocertmanager/autocertmanager.go 94.28% <0.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
pkg/object/httpserver/mux.go Outdated Show resolved Hide resolved
@suchen-sci suchen-sci merged commit 8f0ca6f into easegress-io:main Jan 13, 2023
@samanhappy samanhappy deleted the log branch January 13, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API access log need to be extended to include the header info at least
4 participants