Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support both CORS pre-flight and CORS requests by default #839

Merged
merged 1 commit into from
Oct 31, 2022
Merged

support both CORS pre-flight and CORS requests by default #839

merged 1 commit into from
Oct 31, 2022

Conversation

coderabbit214
Copy link
Contributor

remove supportCORSRequest and support both CORS pre-flight and CORS requests by default

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 76.90% // Head: 76.86% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (34116e2) compared to base (ba3c00a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
- Coverage   76.90%   76.86%   -0.04%     
==========================================
  Files         103      103              
  Lines       11581    11579       -2     
==========================================
- Hits         8906     8900       -6     
- Misses       2168     2172       +4     
  Partials      507      507              
Impacted Files Coverage Δ
pkg/filters/corsadaptor/corsadaptor.go 90.32% <ø> (-0.31%) ⬇️
pkg/filters/validator/basicauth.go 78.80% <0.00%> (-1.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci merged commit c75098f into easegress-io:main Oct 31, 2022
@localvar localvar mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants