introduce server match model for sticky session #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 76.81% // Head: 77.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 76.81% 77.06% +0.25%
==========================================
Files 103 108 +5
Lines 11577 12241 +664
==========================================
+ Hits 8893 9434 +541
- Misses 2176 2282 +106
- Partials 508 525 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
localvar
reviewed
Nov 4, 2022
localvar
reviewed
Nov 4, 2022
Co-authored-by: Bomin Zhang <[email protected]>
localvar
reviewed
Nov 9, 2022
Co-authored-by: Bomin Zhang <[email protected]>
localvar
approved these changes
Nov 11, 2022
suchen-sci
approved these changes
Nov 11, 2022
caoshengdong
pushed a commit
to caoshengdong/easegress
that referenced
this pull request
Dec 20, 2022
* introduce server match model for sticky session * improve performance * apply suggestions * Update pkg/filters/proxy/loadbalance.go Co-authored-by: Bomin Zhang <[email protected]> * rename mode * Update pkg/filters/proxy/loadbalance.go Co-authored-by: Bomin Zhang <[email protected]> * fix typo * support application based model Co-authored-by: Bomin Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to enhance sticky session by introducing a server match model.
The existing model
CookieConsistentHashwill influence a bit stickiness when servers scale out because of re-hashing, but the new model will keep the max stickiness in the same situation by matching server exactly.