Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyfunc for compatibility and bug fixes #837

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Update keyfunc for compatibility and bug fixes #837

merged 2 commits into from
Nov 2, 2022

Conversation

MicahParks
Copy link
Contributor

@MicahParks MicahParks commented Oct 27, 2022

The purpose of this PR is to update the github.com/MicahParks/keyfunc package. The primary reason I'm making this PR is to introduce the changes from these releases:

If there is any interest in the other features added since v1.0.3, please see the release page:
https://github.com/MicahParks/keyfunc/releases

For a quick summary of the new keyfunc.Options, see the documentation for its fields:
https://pkg.go.dev/github.com/MicahParks/keyfunc#Options

Client: httpCli,
JWKUseNoWhitelist: true,
RefreshInterval: interval,
ResponseExtractor: keyfunc.ResponseExtractorStatusAny,
Copy link
Contributor Author

@MicahParks MicahParks Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new options here, JWKUseNoWhitelist and ResponseExtractor are 100% backwards compatible fields. I will remove these fields in an upcoming commit to this PR.

JWKUseNoWhitelist is set to true which means that any use JWK parameter is valid. The project has since changed it's default to only allow those with a use of sig (or empty). See more discussion here.

ResponseExtractor is set to keyfunc.ResponseExtractorStatusAny which means that any HTTP response status code will not produce an error. The project has since changed it's default to only allow http.StatusOK to not produce an error. See more discussion here.

@MicahParks MicahParks marked this pull request as ready for review October 27, 2022 01:30
@codecov-commenter
Copy link

Codecov Report

Base: 76.90% // Head: 76.84% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (85584a6) compared to base (ba3c00a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   76.90%   76.84%   -0.07%     
==========================================
  Files         103      103              
  Lines       11581    11581              
==========================================
- Hits         8906     8899       -7     
- Misses       2168     2174       +6     
- Partials      507      508       +1     
Impacted Files Coverage Δ
pkg/filters/validator/basicauth.go 78.80% <0.00%> (-1.85%) ⬇️
pkg/filters/proxy/pool.go 79.17% <0.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@suchen-sci suchen-sci merged commit b7ba81d into easegress-io:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants