Support agent type and retrieval of deployment spec #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 78.91% // Head: 78.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
+ Coverage 78.91% 78.96% +0.04%
==========================================
Files 101 102 +1
Lines 11170 11234 +64
==========================================
+ Hits 8815 8871 +56
- Misses 1853 1864 +11
+ Partials 502 499 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
localvar
reviewed
Oct 14, 2022
| api.HandleAPIError(w, r, http.StatusNotFound, fmt.Errorf("%s deployment spec not found", serviceName)) | ||
| } | ||
|
|
||
| func (a *API) getConfigMapsAndSecres(spec interface{}) ([]*corev1.ConfigMap, []*corev1.Secret) { |
There was a problem hiding this comment.
Suggested change
| func (a *API) getConfigMapsAndSecres(spec interface{}) ([]*corev1.ConfigMap, []*corev1.Secret) { | |
| func (a *API) getConfigMapsAndSecrets(spec interface{}) ([]*corev1.ConfigMap, []*corev1.Secret) { |
localvar
approved these changes
Oct 14, 2022
suchen-sci
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.