OpenIDConnect v1 implementation #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 79.25% // Head: 77.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
- Coverage 79.25% 77.22% -2.03%
==========================================
Files 101 102 +1
Lines 11188 11466 +278
==========================================
- Hits 8867 8855 -12
- Misses 1826 2112 +286
- Partials 495 499 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
localvar
requested review from
localvar and
suchen-sci
and removed request for
localvar
localvar
reviewed
Oct 13, 2022
localvar
reviewed
Oct 14, 2022
doc/reference/filters.md
Outdated
Comment on lines
1001
to
1004
| OIDC End-User basic profile map json encoded by standard base64 which header name is `X-Userinfo` | ||
| End-User origin request url before OpenID Connect or OAuth2.0 flow which header name is `X-Origin-ReqURL` | ||
| The ID Token returned by OpenID Connect flow which header name is `X-Id-Token` | ||
| The AccessToken returned by OpenId Connect or OAuth2.0 flow which header name is `X-Access-Token` |
There was a problem hiding this comment.
Suggested change
| OIDC End-User basic profile map json encoded by standard base64 which header name is `X-Userinfo` | |
| End-User origin request url before OpenID Connect or OAuth2.0 flow which header name is `X-Origin-ReqURL` | |
| The ID Token returned by OpenID Connect flow which header name is `X-Id-Token` | |
| The AccessToken returned by OpenId Connect or OAuth2.0 flow which header name is `X-Access-Token` | |
| * **X-Userinfo**: Base64 encoded OIDC End-User basic profile. | |
| * **X-Origin-ReqURL**: End-User origin request URL before OpenID Connect or OAuth2.0 flow. | |
| * **X-Id-Token**: The ID Token returned by OpenID Connect flow. | |
| * **X-Access-Token**: The AccessToken returned by OpenId Connect or OAuth2.0 flow. |
and propose X-Userinfo to be X-User-Info, X-Origin-ReqURL to be X-Origin-Request-Url.
Comment on lines
24
to
31
| "github.com/google/uuid" | ||
| "io" | ||
| "io/ioutil" | ||
| "net/http" | ||
| "net/url" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/MicahParks/keyfunc" | ||
| "github.com/golang-jwt/jwt/v4" |
There was a problem hiding this comment.
Suggested change
| "github.com/google/uuid" | |
| "io" | |
| "io/ioutil" | |
| "net/http" | |
| "net/url" | |
| "strings" | |
| "time" | |
| "github.com/MicahParks/keyfunc" | |
| "github.com/golang-jwt/jwt/v4" | |
| "io" | |
| "io/ioutil" | |
| "net/http" | |
| "net/url" | |
| "strings" | |
| "time" | |
| "github.com/google/uuid" | |
| "github.com/golang-jwt/jwt/v4" | |
| "github.com/MicahParks/keyfunc" |
| spec *Spec | ||
| store | ||
|
|
||
| //Following are user custom defined |
There was a problem hiding this comment.
Suggested change
| //Following are user custom defined | |
| // Following are user custom defined |
|
|
||
| Discovery string `json:"discovery"` | ||
|
|
||
| //If Discovery not configured, following should be configured for OAuth2 |
There was a problem hiding this comment.
Suggested change
| //If Discovery not configured, following should be configured for OAuth2 | |
| // If Discovery is not configured, the following should be configured for OAuth2 |
| } | ||
|
|
||
| func (o *OIDCAdaptor) Init() { | ||
| //for testable delegate store interface operation to itself |
There was a problem hiding this comment.
Suggested change
| //for testable delegate store interface operation to itself | |
| // delegate store interface operation to itself for testing |
| if err != nil { | ||
| logger.Errorf("put origin req url error: %s", err) | ||
| } | ||
| //nonce is optional |
There was a problem hiding this comment.
Suggested change
| //nonce is optional | |
| // nonce is optional |
Comment on lines
181
to
184
| for _, c := range req.Cookies() { | ||
| if spec.CookieName == c.Name { | ||
| return "" | ||
| } | ||
| } |
There was a problem hiding this comment.
cookie name is not case-sensitive, propose to call req.Cookie
| logger.Errorf("close error: %s", err) | ||
| } | ||
| }(resp.Body) | ||
| respBody, err := ioutil.ReadAll(resp.Body) |
There was a problem hiding this comment.
ioutil.ReadAll is Deprecated.
Suggested change
| respBody, err := ioutil.ReadAll(resp.Body) | |
| respBody, err := io.ReadAll(resp.Body) |
Comment on lines
240
to
241
| authCode := req.Request.URL.Query().Get("code") | ||
| state := req.Request.URL.Query().Get("state") |
There was a problem hiding this comment.
Suggested change
| authCode := req.Request.URL.Query().Get("code") | |
| state := req.Request.URL.Query().Get("state") | |
| authCode := req.Std().URL.Query().Get("code") | |
| state := req.Std().URL.Query().Get("state") |
Comment on lines
267
to
268
| mapClaims, _ := parseToken.Claims.(jwt.MapClaims) | ||
| for k, v := range mapClaims { | ||
| userInfo[k] = v | ||
| } |
There was a problem hiding this comment.
Suggested change
| mapClaims, _ := parseToken.Claims.(jwt.MapClaims) | |
| for k, v := range mapClaims { | |
| userInfo[k] = v | |
| } | |
| if claims, ok := parseToken.Claims.(jwt.MapClaims); ok { | |
| userInfo = claims | |
| } |
localvar
approved these changes
Oct 17, 2022
suchen-sci
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenIDConnect integration implementation #827