add debug log for matched pipeline #771
Conversation
Codecov ReportBase: 78.85% // Head: 78.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
==========================================
- Coverage 78.85% 78.83% -0.03%
==========================================
Files 101 101
Lines 11166 11168 +2
==========================================
- Hits 8805 8804 -1
- Misses 1857 1859 +2
- Partials 504 505 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pkg/object/httpserver/mux.go
Outdated
| buildFailureResponse(ctx, http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
| logger.Debugf("%s: the matched backend(Pipeline) is %s", mi.superSpec.Name(), route.path.backend) |
There was a problem hiding this comment.
More info about the matched request?
There was a problem hiding this comment.
More info about the matched request?
Yes，we need client request URI，matched configured path，matched path backend
There was a problem hiding this comment.
there could be many fields in the matched path, including headers and methods, which makes it not suitable for logging.
I think the request URI and matched backend is enough to help find the wrong rule, so I prefer not to include the matched path.
any comments?
There was a problem hiding this comment.
Logging the method would be a good cost-effective addition
No description provided.