Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default failure codes 5xx #757

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Conversation

xxx7xxxx
Copy link
Contributor

Fix #689

@localvar
Copy link
Collaborator

please update the document to mention the default values: https://github.com/megaease/easegress/blob/main/doc/reference/filters.md#proxyserverpoolspec

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #757 (87043e3) into main (ea86a0e) will decrease coverage by 0.08%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   80.44%   80.35%   -0.09%     
==========================================
  Files          97       97              
  Lines       10790    10798       +8     
==========================================
- Hits         8680     8677       -3     
- Misses       1623     1631       +8     
- Partials      487      490       +3     
Impacted Files Coverage Δ
pkg/object/meshcontroller/spec/spec.go 68.96% <ø> (ø)
pkg/filters/proxy/pool.go 76.00% <30.00%> (-0.74%) ⬇️
pkg/cluster/cluster.go 60.10% <0.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@suchen-sci
Copy link
Contributor

should we keep a way to not set failureCode? since failureCode is a result of proxy and may influence the execution of pipeline...

@xxx7xxxx
Copy link
Contributor Author

xxx7xxxx commented Aug 12, 2022

please update the document to mention the default values

Document updated.

should we keep a way to not set failureCode? since failureCode is a result of proxy and may influence the execution of pipeline...

Yes, it's very annoying to manually set it one by one e.g [500, 501, 502...]. Because most time 5xx stands for server error, which would be a failure indication for circuit breaker and retry. [1]

[1] https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_server_errors

@suchen-sci suchen-sci merged commit 68861a9 into easegress-io:main Aug 12, 2022
@xxx7xxxx xxx7xxxx deleted the failure-codes branch August 29, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support default failureCodes
4 participants