Release 2.1.0 #750
Release 2.1.0 #750
Conversation
pkg/filters/builder/builder.go
Outdated
| @@ -76,7 +76,7 @@ func (b *Builder) build(data map[string]interface{}, v interface{}) error { | |||
| return err | |||
| } | |||
|
|
|||
| return codectool.Decode(&result, v) | |||
| return yaml.Unmarshal(result.Bytes(), v) | |||
There was a problem hiding this comment.
It's consistent to use codecool.UnmarshalYAML in case of replacing the vendor in one time and one place.
There was a problem hiding this comment.
ok, I will switch to that function.
pkg/protocols/httpprot/request.go
Outdated
| Headers map[string][]string `json:"headers" jsonschema:"omitempty"` | ||
| Body string `json:"body" jsonschema:"omitempty"` | ||
| FormData map[string]field `json:"formData" jsonschema:"omitempty"` | ||
| Method string `json:"method" yaml:"method" jsonschema:"omitempty"` |
There was a problem hiding this comment.
The megaease dedicated yaml vendor will use json tag if there is no yaml tag.
There was a problem hiding this comment.
I think making it explicit would be better because this is a "YAML in YAML" case.
There was a problem hiding this comment.
Sure, would you mind adding a line of comment about it
|
no release note and change log... |
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
==========================================
- Coverage 80.49% 80.33% -0.16%
==========================================
Files 97 97
Lines 10785 10785
==========================================
- Hits 8681 8664 -17
- Misses 1619 1631 +12
- Partials 485 490 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
No description provided.