Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mqtt client close strategy for main #741

Merged

Conversation

suchen-sci
Copy link
Contributor

Same to pr #740

@localvar localvar self-requested a review August 2, 2022 06:13
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #741 (91caa90) into main (7d9f590) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   80.38%   80.46%   +0.07%     
==========================================
  Files          98       98              
  Lines       10701    10702       +1     
==========================================
+ Hits         8602     8611       +9     
+ Misses       1609     1603       -6     
+ Partials      490      488       -2     
Impacted Files Coverage Δ
pkg/object/mqttproxy/client.go 82.51% <100.00%> (+1.88%) ⬆️
pkg/object/autocertmanager/autocertmanager.go 94.28% <0.00%> (+0.81%) ⬆️
pkg/filters/headerlookup/headerlookup.go 86.01% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9f590...91caa90. Read the comment docs.

@zhao-kun zhao-kun merged commit cd73ce5 into easegress-io:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants