fix #738 panic in demo #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 80.38% 80.40% +0.01%
==========================================
Files 98 98
Lines 10701 10701
==========================================
+ Hits 8602 8604 +2
+ Misses 1609 1607 -2
Partials 490 490
Continue to review full report at Codecov.
|
xxx7xxxx
reviewed
Aug 2, 2022
| @@ -235,8 +235,7 @@ func (ssc *StatusSyncController) syncStatusToCluster(statusUnits map[string]*sta | |||
| if ssc.lastSyncStatusUnits != nil { | |||
| kvs := make(map[string]*string) | |||
| for k := range ssc.lastSyncStatusUnits { | |||
| if su, exists := statusUnits[k]; !exists { | |||
| k = su.clusterKey(ssc.superSpec.Super().Cluster().Layout()) | |||
| if _, exists := statusUnits[k]; !exists { | |||
There was a problem hiding this comment.
for k, su := range ssc.lastSyncStatusUnits {
if _, exists := statusUnits[k]; !exists {
key := su.clusterKey(ssc.superSpec.Super().Cluster().Layout())
kvs[key] = nil
}
}It seems this kind of change will fix the problem totally, how about testing and applying it?
xxx7xxxx
approved these changes
Aug 2, 2022
localvar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.